Merged
Conversation
This reverts commit 3469cd1.
|
It looks good to me @LiamConnors . Should we ask someone from graphing library team to review that as well? Please squash / merge so we end up with one commit that is easy to revert down the road if needed :) |
antoinerg
approved these changes
Mar 10, 2026
2 tasks
LiamConnors
changed the title
camdecoster
approved these changes
Mar 30, 2026
Contributor
camdecoster
left a comment
camdecoster
left a comment
There was a problem hiding this comment.
I left a couple of suggestions, but this looks good.
Comment on lines
+36
to
+38
| - name: Set up Mapbox token | ||
| run: | | ||
| echo "token: ${{ secrets.MAPBOX_TOKEN }}" > _data/mapbox_token.yml |
Contributor
There was a problem hiding this comment.
This is fine as is, but why make it a separate step?
Member
Author
There was a problem hiding this comment.
I felt it was cleaner and easier to read to keep all these setup steps separate
_posts/plotly_js/fundamentals/annotations/2015-04-09-annotations_plotly_js_index.html
Show resolved
Hide resolved
LiamConnors
commented
Mar 30, 2026
_posts/plotly_js/fundamentals/annotations/2015-04-09-annotations_plotly_js_index.html
Outdated
Show resolved
Hide resolved
LiamConnors
commented
Mar 30, 2026
_posts/plotly_js/fundamentals/plotly-js-3-changes/2024-10-09-plotly-js-3-changes.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This workflow uses the output of plotly/plotly.py#5541 to build the docs